PointCloudLibrary/pcl

Replace pcl::visualization::createPlane and pcl::visualization::PCLVisualizer::addPlane overloads by default arguments

Open

#1,653 opened on 2016年7月18日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
good first issuekind: todomodule: visualization

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (平均マージ 8d 7h) (30d で 3 merged PRs)

説明

The code is pretty similar and can be probably reduced by simply making a change to its signature with default initializers.

bool addPlane (const pcl::ModelCoefficients &coefficients, 
               double x = 0,
               double y = 0,
               double z = 0,
               const std::string &id = "plane",
               int viewport = 0);

and

PCL_EXPORTS vtkSmartPointer<vtkDataSet> 
createPlane (const pcl::ModelCoefficients &coefficients, double x = 0, double y = 0, double z = 0);

pcl::visualization::PCLVisualizer::addPlane method:

pcl::visualization::createPlane method:

コントリビューターガイド