Pioreactor/pioreactor

turn callback helpers in ODReader to decorators

Open

#359 opened on 2022年12月2日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Python (17 forks)github user discovery
enhancementfuturegood first issue

Repository metrics

Stars
 (140 stars)
PR merge metrics
 (平均マージ 2h 18m) (30d で 1 merged PR)

説明

Current:

from pioreactor.background_jobs.od_reading import ODReader

# example of using callbacks to OD reading...

def hello(self):
    print(f"Hello, {self}!")


def goodbye(self, readings):
    print(f"Goodbye, {self}, witnessed {readings}!")

ODReader.add_pre_read_callback(hello)
ODReader.add_post_read_callback(goodbye)

Desired:

from pioreactor.background_jobs.od_reading import ODReader

# example of using callbacks to OD reading...

@ODReader.add_pre_read_callback
def hello(self):
    print(f"Hello, {self}!")


@ODReader.add_post_read_callback
def goodbye(self, readings):
    print(f"Goodbye, {self}, witnessed {readings}!")

コントリビューターガイド