PathOfBuildingCommunity/PathOfBuilding

An option for "DO NOT COMPARE WITH CLUSTER JEWELS"

Open

#6,275 opened on 2023年7月8日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
enhancementgood first issue

説明

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Currently, I have lots of jewels and try to find an upgrade I find an item or craft a custom one, and POB compares it with all jewels... But comparing it with existing cluster jewels makes no sense, and it should be hidden, or at least it should be an option, and by default, it should be set to FALSE

Describe the solution you'd like

Add an option to "Options" section that says,

  • Compare jewels with existing clusetr jewels - CHECKBOX, default unchecked

Describe alternatives you've considered

No response

Additional context

image

コントリビューターガイド

技術スタック
lua
領域
desktoptooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Lua basicsPathOfBuilding UI understanding
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Check the jewel comparison logic in PathOfBuilding's source code. Look for existing options in the UI, such as checkboxes in the Options menu, to understand the pattern. The feature likely requires adding a new option flag and modifying the comparison function to skip cluster jewels when the flag is set. Examine files like 'src/Classes/Item.lua' or UI related scripts for comparison logic.