PathOfBuildingCommunity/PathOfBuilding

Arcane cloak breaks a lot of calculations if used with negative unreserved mana

Open

#5,411 opened on 2022年12月19日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
bug: calculationgood first issue

説明

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation ingame?

If you have "negative reservation" it should simply acts as consuming 0 mana rather than a negative amount.

What is the value from the calculation in Path of Building?

It assume negative mana breaking damage and max hit calculations image

How to reproduce the issue

Reserve more than 100% of mana See broken calculations

Character build code

https://poe.ninja/pob/Mi1

Screenshots

No response

コントリビューターガイド

技術スタック
lua
領域
desktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Lua programmingPath of Exile game mechanics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
55
調査方針
The bug occurs with Arcane Cloak causing negative unreserved mana. The fix should clamp negative mana reservation to zero before calculations. Investigate the mana reservation code in the 'calc' or 'data' modules, such as functions computing unreserved mana. Look at the Arcane Cloak implementation and how negative values propagate to damage and max hit calculations.