ParadiseSS13/Paradise

The *sign emote accepts any number outside its stated 0-10 range

Open

#30,940 opened on 2025年11月9日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
Good First IssueOversight

説明

BYOND Version

516.1669

Issue Description

The *help list states: "sign[-number(0-10)]", which implies that only numbers between 0 and 10 can be used. Instead, it accepts any kind of number, including numbers outside the 0-10 range.

What did you expect to happen?

I expected to only be able to use numbers between 0 and 10.

What happened instead?

I was able to use any number, including negative numbers and decimals, though I don't know if being able to use decimals is intended or not.

Why is this bad/What are the consequences?

The *help list shouldn't lie to the player.

Steps to reproduce the issue.

Say "*sign-#" where # is any number you want. Notice that you can sign numbers such as -100000 or 9999999999999.

When did the problem start happening?

I only used the sign emote for the first time today.

Extra information

The sign emote was re-added in #29872

Relevant log output/runtime error

コントリビューターガイド

技術スタック
なし
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
locate sign emote validation code
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
85
調査方針
Investigate the sign emote implementation introduced in PR #29872. Locate where the numeric argument is parsed and add a validation to restrict it to integers between 0 and 10. Ensure the help text is updated to reflect the correct range.