ParadiseSS13/Paradise

Infrared lasers work even in a backpack/locker/etc

Open

#15,958 opened on 2021年4月28日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
BugGood First Issue

説明

Issue Description:

Tripwire laser mines (chem grenades using infrared as detonator) will check in the direction they're set even if they are in a container. Logically, the laser shouldnt pierce through?

What did you expect to happen:

Nothing.

What happened instead:

Tripwire is triggered by somebody walking in front of a locked locker.

Why is this bad/What are the consequences:

Makes it much easier to hide tripwire mines. Not logical.

Steps to reproduce the problem:

  1. Make a tripwire mine chem grenade
  2. Set it to activated, with any direction or invisibility setting
  3. Walk in front of it in the direction set, boom

When did the problem start happening:

Likely long living oversight

コントリビューターガイド

技術スタック
なし
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of SS13 object hierarchyBasic knowledge of DM scripting
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Examine the infrared detonator code, likely in `code/game/objects/items/grenades/infrared.dm` or similar. Look for the laser scanning logic that checks line of sight. The fix should add a condition to verify that the mine is not inside a container (e.g., backpack, locker) before triggering. Check the `loc` variable to determine if the item is inside another atom. Reference the issue comments for any additional context.