POSYDON-code/POSYDON

He-rich stars being directed to step_HMS_HMS_RLO

オープン

#448 opened on 2024/11/22

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Python (35 件のフォーク)auto 404
good first issue

Repository metrics

Stars
 (42 個のスター)
PR merge metrics
 (PR metrics pending)

説明

In the initial_eccentricity_flow_chart, both H-rich and He-rich stars in RLO are being directed to step_HMS_HMS_RLO. However, this step does not actually handle the He-rich stars, it just fails them because they are not in the FOR_RLO_STATES. This should be corrected so that these stars are better handled in the flow, ensuring the changes are also consistent with the error catching for RLO binaries with H-rich stars in the detached step (e.g. PR #430).

コントリビューターガイド