POSYDON-code/POSYDON

Clean out duplicated functions and variables

オープン

#442 opened on 2024/11/21

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Python (35 件のフォーク)auto 404
enhancementgood first issuev2 feature

Repository metrics

Stars
 (42 個のスター)
PR merge metrics
 (PR metrics pending)

説明

We have different functions and variables which have duplicates. We should clean that up to always use one version. Here some examples

  • posydon.utils.gridutils.kepler3_a vs. posydon.utils.common_functions.orbital_separation_from_period
  • posydon.utils.gridutils.T_merger_P vs. posydon.utils.common_functions.inspiral_timescale_from_orbital_period
  • posydon.utils.gridutils.T_merger_a vs. posydon.utils.common_functions.inspiral_timescale_from_separation
  • variables are often hard coded in functions instead of imported from where they are defined, this happens often in step_* vs. flow_chart

コントリビューターガイド