OpenZeppelin/openzeppelin-contracts
Consider adding an ESLint rule for no async in describe blocks
クローズ
#4,943 opened on 2024/03/06
good first issuetests
Repository metrics
- Stars
- (23,941 個のスター)
- PR merge metrics
- (平均マージ 42d 15h) (30d で 16 merged PRs)
説明
From @fvictorio:
I forgot to mention:
- The wrong
asynckeywords in describe functions can be prevented with this rule.- The missing
awaitkeywords are harder. Ideally you'd use typescript and theno-floating-promisesrule, but I understand that that would be a huge undertaking.Originally posted by @fvictorio in https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4942#issuecomment-1980874051
We're considering adding only the ESLint rule and not migrating to Typescript to catch floating promises. However, we're open to alternatives.