OpenXRay/xray-16

Get rid of Loki

オープン

#240 opened on 2018/09/09

 (3 件のコメント) (2 件のリアクション) (0 人の担当者)C++ (519 件のフォーク)auto 404
Code QualityExternal (3rd party)Help wantedPortability

Repository metrics

Stars
 (3,524 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Loki is a C++ library found in the sdk folder. There are several reasons to remove it:

  • Most of the stuff of this library, written for C++98 by Andrei Alexandrescu, can be found in C++11, e.g. Loki::Select is just std::conditional, Loki::IsSameType can be replaced with std::is_same.
  • Some of the code does not compile in GCC. (With some changes, it compiled in GCC)
  • The things that haven't been included in modern C++, can be rewritten with fewer lines of code.
  • It's barely used.

コントリビューターガイド