OpenFeign/feign

Allow for 3xx range headers

Open

#249 opened on 2015年7月12日

GitHub で見る
 (28 comments) (0 reactions) (0 assignees)Java (1,911 forks)batch import
documentationhelp wanted

Repository metrics

Stars
 (9,070 stars)
PR merge metrics
 (平均マージ 2d 17h) (30d で 71 merged PRs)

説明

Everything above 299 is considered an error, which is plainly incorrect.

To get around this I had to:

  1. add an error decoder
  2. throw a special exception for 3xx range
  3. when catching runtime errors, check if it is the special 300 error
  4. convert to a valid response entity

Will investigate replacing this line:

if (response.status() >= 200 && response.status() < 300) { in SynchronousMethodHandler and PR'ing it. I just wonder why nobody else has come across this issue.

Should I fix it?

コントリビューターガイド