OpenFeign/feign

feign-mock is too strict with request headers when matching requests

オープン

#1,552 opened on 2021/12/20

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Java (1,911 件のフォーク)batch import
help wantedproposal

Repository metrics

Stars
 (9,070 個のスター)
PR merge metrics
 (PR metrics pending)

説明

I am using https://github.com/OpenFeign/feign/tree/master/mock to write unit tests. When one would want to match/verify request headers, the current implementation seems too strict as it checks for exact equality. Ideally, it should be matching a subset of the headers as there can be headers the tester doesn't care about or generated headers like Content-Length.

I know the workaround for this is to write a RequestInterceptor and do assertions there, but that is not ideal as it adds a lot of boilerplate code in tests. For each test, one needs to write a test-specific RequestInterceptor.

I would like to propose making the header matching in RequestKey.java#L171 match a subset of the headers instead of exact equality.

Bonus Request: match with RegEx

コントリビューターガイド