OpenChemistry/avogadrolibs
Export to MP4 should test for "avconv" in path
オープン
#282 opened on 2018/06/18
bughacktoberfest
Repository metrics
- Stars
- (662 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
This requires avconv to be installed in the system. If avconv is not installed, this particular snippet still executes, but no mp4 file is saved and there is no warning or error thrown saying that avconv is not found.
https://github.com/OpenChemistry/avogadrolibs/blob/da6ebb9f0e39c73ca861001e390d13e6ed3e6cb5/avogadro/qtplugins/playertool/playertool.cpp#L232
In Windows, the png export itself isn't taking place. avconv execution will also presumably fail I guess.
Should we resort to including libraries for these in the build?