OpenAPITools/openapi-generator

[REQ][php] declareStrictTypes option for all PHP generators

オープン

#12,771 opened on 2022/07/05

 (2 件のコメント) (4 件のリアクション) (0 人の担当者)Java (7,516 件のフォーク)batch import
Client: PHPEnhancement: FeatureGood First IssueServer: PHP

Repository metrics

Stars
 (26,243 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Is your feature request related to a problem? Please describe.

Usually I totally against codegen options which modifies one line of code, but this one looks really handy.

Describe the solution you'd like

Add declareStrictTypes switch option to AbstractPhpCodegen class, then:

openapi-generator-cli generate -g php --additional-properties=declareStrictTypes=true \
    -o out -i petstore.yaml

then in all mustache files:

<?php 

{{#declareStrictTypes}}declare(strict_types=1);{{/declareStrictTypes}}

We also need to decide whether this switch option should be on or off by default. I think it should be on, but it can cause breaking changes.

Describe alternatives you've considered

Close this issue as not necessary feature 😆

Additional context

cc @jebentier @dkarlovi @mandrean @jfastnacht @renepardon

コントリビューターガイド