NuGet/Home

RestoreLockedMode=true & RestoreForceEvaluate=true should error

クローズ

#8,222 opened on 2019/06/13

 (6 件のコメント) (1 件のリアクション) (1 人の担当者)HTML (292 件のフォーク)batch import
Area:ErrorHandlingArea:RestoreRepeatableBuildCategory:Quality WeekFunctionality:RestorePriority:2Type:Bughelp wanted

Repository metrics

Stars
 (1,459 個のスター)
PR merge metrics
 (平均マージ 464d 23h) (30d で 1 merged PR)

説明

Currently that's not the case.

Repro steps

  1. dotnet new classlib
  2. Enable lock file
  3. dotnet restore (generate lock file).
  4. dotnet restore /p:LockedMode="true"
  5. dotnet restore /p:LockedMode="true" /p:RestoreForceEvaluate="true"

The last one should fail, as the instructions do not make sense. From skimming the code, RestoreForceEvaluate takes precedence.

https://github.com/NuGet/NuGet.Client/blob/bdcec93681afdd1f5cd553af07414a3b3d9a866c/src/NuGet.Core/NuGet.Commands/RestoreCommand/RestoreCommand.cs#L462

//cc @anangaur It's a trivial fix, so prioritize if you see a need for it.

コントリビューターガイド