NethermindEth/starknet.go

Specific return type for BlockWithTxs and BlockWithTxHashes methods

オープン

#355 opened on 2023/09/22

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Go (140 件のフォーク)auto 404
help wanted

Repository metrics

Stars
 (177 個のスター)
PR merge metrics
 (PR metrics pending)

説明

In https://github.com/NethermindEth/starknet.go/pull/354 a new type for blocks with only transaction hashes was created as requested on #347.

However, BlockWithTxs and BlockWithTxHashes methods still have as return type interface{} as these can return either a Block or a Pending Block in both cases. The idea is to replace interface{} with an specific type and do something similar as in TransactionByHash method (see here) with adaptTransaction

コントリビューターガイド