Midburn/spark

Clean global scope in all controllers.

オープン

#980 opened on 2018/11/29

 (1 件のコメント) (0 件のリアクション) (1 人の担当者)JavaScript (44 件のフォーク)auto 404
Cleanupgood first issue

Repository metrics

Stars
 (18 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Overview of the problem

We have several functions declared globally in controller files. This can create issues hard to anticipate and solve.

Description

  1. We need to move all functions into scope. image image
  2. We need to make sure the functions aren't used in any other file (if so, we should create an AngularJS service to be shared between the controllers)
  3. Sanity after the cleanup - check most screens and buttons don't raise exceptions related to missing functions.

Expected behavior

Functions should be scoped

Actual behavior

Functions are declared outside of AngularJS's controllers call back

コントリビューターガイド