Microsoft/vscode

Git - add of file with unicode name fails in Git panel

Open

#41,246 opened on 2018年1月7日

GitHub で見る
 (29 comments) (1 reaction) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
buggithelp wanted

説明

  • VSCode Version: Code 1.19.1 (0759f77bb8d86658bc935a10a64f6182c5a1eeba, 2017-12-19T09:46:02.926Z)
  • OS Version: Windows_NT ia32 10.0.16299
  • Extensions:
Extension Author (truncated) Version
vscode-base64 ada 0.0.1
vscode-database baj 1.2.0
toml be5 0.0.3
vscode-markdownlint Dav 0.12.0
createuniqueid don 0.0.3
githistory don 0.2.3
EditorConfig Edi 0.11.1
git-project-manager fel 1.4.0
mdmath goe 2.1.0
vscode-wordcount-cjk hol 1.0.0
Ionide-FAKE Ion 1.2.3
Ionide-fsharp Ion 3.15.7
Ionide-Paket Ion 1.8.1
copy-markdown-as-html jer 1.0.0
golang-tdd joa 0.0.9
Go luk 0.6.71
reflow-markdown mar 1.3.0
azure-account ms- 0.2.2
csharp ms- 1.13.1
vscode-docker Pet 0.0.23
vscode-icons rob 7.19.0
go-test-outline Rom 0.1.4
rust rus 0.3.2
vscode-autohotkey sle 0.2.1
vscode-helm tec 0.3.0
vscode-lldb vad 0.7.3
vim vsc 0.10.8
debug web 0.21.2

Steps to Reproduce:

  1. Initialize a git repository and open the folder in VSCode.
  2. Create a new file named defaŭlto.html.
  3. From the VSCode Git panel, use the "+" icon to stage the new file.
  4. Error reported: fatal: pathspec 'c:\…\defaulto.html' did not match any files

Git log reports that it ran the following command: "git add -A -- c:\…\defaŭlto.html"

Running the same command from the git command line in Powershell works without a problem, but also fails from the normal Windows command prompt. Reviewing StackOverflow and other locations, it appears that this is a limitation of the Windows command prompt, but I thought I would document it here since it has a knock-on effect for the Git panel.

Reproduces without extensions: Yes

コントリビューターガイド

技術スタック
typescriptnodejs
領域
desktopdeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
VSCode Git integration basicsWindows character encoding awareness
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Examine VSCode's Git extension code in `src/vs/workbench/parts/git/common/git.ts` to see how file paths are passed to `git add`. Note that the issue occurs only from cmd but not PowerShell; investigate the shell used by VSCode on Windows (likely cmd). Consider using `git c core.quotepath=false` or ensuring proper Unicode handling. Check for existing tests for Unicode filenames. Possible fix: switch to PowerShell or escape the path appropriately.
Git - add of file with unicode name fails in Git panel · Microsoft/vscode#41246 | Good First Issue