Microsoft/vscode
Don't prompt for user confirmation when workspace typescript.tsserver.nodePath is set to "node"
オープン
#200,923 opened on 2023/12/15
feature-requesthelp wantedtypescript
Repository metrics
- Stars
- (184,936 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
We had this awesome feature merged #191019. This will allow our team to get off the custom tsserver implementation we have been using and just use this new setting for everyone.
One issue is that right now when we have a workspace setting for "typescript.tsserver.nodePath" set to "node" (i.e. auto-detect node installation) we get a prompt as shown below
I would argue that if the setting is "node" then we are using a user-installed nodejs installation and we don't need to ask for this prompt, because it's user installed and if there are security risks then user has already accepted them with the nodejs installation.
Happy to create a PR to update this if someone can confirm that it's Ok to make this change.