Microsoft/vscode

Disposing a webview view when extension host is restarted

Open

#188,257 opened on 2023年7月19日

GitHub で見る
 (2 comments) (9 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
bughelp wantedwebview-views

説明

Originally in https://github.com/microsoft/vscode-pull-request-github/issues/4872#issuecomment-1573555380

Here is what I see happen:

  1. Open a folder
  2. Have an extension that creates a webview view
  3. Keep the webview view open
  4. Add a folder to the workspace, which causes the extension host to be restarted.
  5. The extension's deactivate gets called as expected. In deactivate the extension disposes of the webview view provider.
  6. With this dispose I would expect the webview view to hide, but it does not.

You can easily reproduce the above using the GitHub Pull Request extension with the steps linked from the original issue.

コントリビューターガイド

技術スタック
typescriptnodejs
領域
frontenddeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
VSCode extension APIwebview view lifecycle
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Investigate the webview view provider disposal mechanism in VSCode. Look at the extension host restart sequence and the lifecycle of webview views. The issue mentions that dispose() is called but the view does not hide. Check files related to webview view rendering and extension host communication. Consider looking at the linked original issue for more context.