Microsoft/vscode

Custom editors should not allow to make edits after extension host restart

Open

#184,142 opened on 2023年6月2日

GitHub で見る
 (2 comments) (1 reaction) (1 assignee)TypeScript (10,221 forks)batch import
bugcustom-editorshelp wanted

Repository metrics

Stars
 (74,848 stars)
PR merge metrics
 (平均マージ 11h 43m) (30d で 1,000 merged PRs)

説明

This is a follow up from https://github.com/microsoft/vscode/issues/180514

When the EH restarts with an opened custom editor, that editor continues to be editable but does not report any dirty indication and does not allow to be saved because the old EH it was talking to is gone.

Recording 2023-06-02 at 10 50 46

I think a custom editor should detect that it lost the connection to its extension on the EH side and then do something, such as:

  • turn readonly to prevent further edits
  • show an indication to the user what happened

//cc @Tyriar

コントリビューターガイド