Microsoft/vscode

Explore file watcher handling of verbose VS Code CLI commands

Open

#141,488 opened on 2022年1月25日

GitHub で見る
 (2 comments) (0 reactions) (1 assignee)TypeScript (74,848 stars) (10,221 forks)batch import
debtengineeringhelp wantedmacosmacos-big-surworkbench-cli

説明

Ref https://github.com/microsoft/vscode/issues/141053

Currently:

  • The CLI process on macOS (Big Sur and above) spawns the main process using the open command so that VS Code is launched with the correct entitlements.
  • the open command can only redirect stdout and stderr to files, so we currently create temp files for the open command, and then set up file watchers on the CLI process to detect when those files are being written to.
  • code-insiders --status and code-insiders --verbose both require the setup with the file watchers.
  • :bug: When the main process exits, the CLI process cancels the filewatching, but the watcher might not have finished reading through the file yet. Therefore, some of the expected output is cut off early at the end.

A mitigation is to add in a timeout so that there is a delay between the main process exiting and the filewatcher being cancelled, but there should be a better way to detect when to stop watching. Actually, the issue reminds me a bit of flush() methods in other contexts.

コントリビューターガイド

技術スタック
typescriptnodejselectron
領域
clidesktop
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
understanding of file watchersmacOS developmentVS Code CLI
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Investigate the file watcher mechanism for CLI output in VS Code on macOS. The issue references #141053 and describes a race condition between main process exit and file watcher cancellation. Look at the CLI process spawning code and the file watching implementation in the main process. There is an assignee; check if any ongoing work or comments provide additional context. Focus on finding a reliable way to detect when all output has been read before cancelling the watcher.