Microsoft/monaco-editor

[Bug] Many duplicates in minified tsWorker.js leading to large file

Open

#4,184 opened on 2023年9月22日

GitHub で見る
 (3 comments) (1 reaction) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
debthelp wanted

説明

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Reproduction Steps

  1. Open a compiled version of the file min/vs/language/typescript/tsWorker.min.js CDN Example
  2. Optionally copy the code in a VS Code window
  3. Search for interface CanvasDrawPath {
  4. Note that the definition is found twice
  5. This duplication issue is the case for a lot of code

Code20230923 - 0129

Actual (Problematic) Behavior

The minified version of tsWorker.js is around 4.6 MB I want to use the Monaco editor in a web extension, but this allows a maximum file size of 4 MB

If the code duplication is fixed, that would reduce the filesize enough to get below 4 MB

Expected Behavior

No duplicate code generated during the build

Additional Context

Related Add_ons Linter issue https://github.com/mozilla/addons-linter/issues/3915

コントリビューターガイド

技術スタック
typescriptjavascript
領域
performancebuild system
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Understanding of build tools (webpack)Familiarity with minification
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Examine the build configuration for tsWorker, likely in webpack config. Investigate how TypeScript lib declarations are bundled and minified, possibly causing duplication. Check if there's a deduplication plugin or if the build process can be adjusted to avoid including duplicate declarations. Refer to the related addons linter issue for context.
[Bug] Many duplicates in minified tsWorker.js leading to large file · Microsoft/monaco-editor#4184 | Good First Issue