Microsoft/monaco-editor

[Bug] Cannot load `monaco-editor` esm module within Deno for bundling to the client.

Open

#3,501 opened on 2023年1月9日

GitHub で見る
 (3 comments) (2 reactions) (0 assignees)JavaScript (1,283 forks)batch import
feature-requesthelp wantedintegration

Repository metrics

Stars
 (14,836 stars)
PR merge metrics
 (平均マージ 6h 26m) (30d で 15 merged PRs)

説明

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Reproduction Steps

Can be reproduced by following the instructions on this example repo.

https://github.com/cowboyd/monaco-fresh#static-import

Actual (Problematic) Behavior

Just loading the monaco-editor module (not using it) fails because of this code https://github.com/microsoft/vscode/blob/12e6b0b3043f19d0cf1730eb3c213d3930310053/src/vs/base/browser/canIUse.ts#L21-L23

It appears that there has is specific carve out so that the code will run on NodeJS with the check for platform.isNative, but platform.isNative is false when running on Deno.

Expected Behavior

The ES module should be loaded successfully, even though you never call editor.create().

コントリビューターガイド