Microsoft/monaco-editor

Improve Go syntax highlighting

Open

#1,770 opened on 2020年1月17日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (14,836 stars) (1,283 forks)batch import
feature-requestgrammarshelp wantedopen for PR

説明

monaco-editor version: 0.19.3 Browser: Chrome 79 maybe OS: macOS Mojave Playground code that reproduces the issue:

monaco.editor.create(document.getElementById("container"), {
	value: 'fmt.Println("666")',
	language: "go"
});

How Monaco/Monarch highlights things:

image

How VSCode highlights things:

Also in VSCode (latest, not Insiders) that line of code is highlighted differently once rendered from Markdown, I think it's ok to expect some differences since my editor has a dark background and the rendered Markdown has a light background, but here a method's name is no longer of a different color as far as I can see, and that seems a bit too much of a difference:

コントリビューターガイド

技術スタック
gojavascripttypescript
領域
frontenddeveloper experience
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with Go syntaxUnderstanding of Monarch tokenizerBasic JavaScript/TypeScript
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Examine the Go language definition file (likely src/basic languages/go/go.ts) to compare the tokenizer rules with VSCode's Go highlighting. Identify the rules that produce incorrect colors for string literals and method names. Adjust the Monarch tokenizer rules to match VSCode's output, ensuring string literals are colored correctly and method names are distinguished from regular function calls. Test the changes locally using the Monaco editor development environment.