Missing constraint error in instantiation expression for a nested class
#61,982 opened on 2025幎7æ1æ¥
Repository metrics
- Stars
- Â (48,455 stars)
- PR merge metrics
-  (å¹³åããŒãž 6d 17h) (30d ã§ 9 merged PRs)
説æ
ð Search Terms
instantiation expression caching class expression declaration type arguments type parameter
ð Version & Regression Information
- This changed in PR: https://github.com/microsoft/TypeScript/pull/59931 , cc @weswigham
⯠Playground Link
ð» Code
class A<T = number> {
value!: T;
child!: InstanceType<typeof A.B<A<T>>>; // this should error
static B = class B<T extends A = A> {
parent!: T;
};
}
ð Actual behavior
It doesn't error
ð Expected behavior
it should error with:
Type 'A<T>' does not satisfy the constraint 'A<number>'.
Type 'T' is not assignable to type 'number'.(2344)
like it did in 5.6: TS playground
Additional information about the issue
The problem here is that the situation is a little bit circular and variances worker gets hits in reentrant manner. The nested call returns emptyArray that is a signal for structuredTypeRelatedToWorker to return Ternary.Unknown.
So checkTypeArguments called by getInstantiatedSignatures doesn't report an error. In the old version of the code, this would be re-called after the variance worker would completely exit and the error would be raised.
I see 2 ways to solve this:
- ignore the introduced caching based
inVarianceComputationto avoid spoiling this - defer
checkTypeArgumentsingetInstantiatedSignatures(well, call it with/*reportErrors*/ falseand defer anoher call with/*reportErrors*/ true)