Microsoft/TypeScript

[type bug] fontfaces property is missing from loadingdone event object

Open

#51,885 opened on 2022年12月14日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (平均マージ 6d 17h) (30d で 9 merged PRs)

説明

Configuration Check

My compilation target is ES2015 and my lib is ES2022 & `DOM.

Missing / Incorrect Definition

Request to replace the event type of onloadingdone handler from Event to FontFaceSetLoadEvent, which has been defined in the same module.

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5530

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5548-L5550

Sample Code

interface FontFaceSet extends EventTarget {
-    onloadingdone: ((this: FontFaceSet, ev: Event) => any) | null;
+    onloadingdone: ((this: FontFaceSet, ev: FontFaceSetLoadEvent) => any) | null;
}

Documentation Link

https://w3c.github.io/csswg-drafts/css-font-loading/#FontFaceSet-events

コントリビューターガイド