Microsoft/TypeScript

Condition aliasing doesn't capture optional chain expressions

Open

#49,075 opened on 2022幎5月11日

GitHub で芋る
 (4 comments) (1 reaction) (0 assignees)TypeScript (6,726 forks)batch import
BugDomain: check: Control FlowHelp Wanted

Repository metrics

Stars
 (48,455 stars)
PR merge metrics
 (平均マヌゞ 6d 17h) (30d で 9 merged PRs)

説明

Bug Report

🔎 Search Terms

undefined optional chain aliased condition narrowing

🕗 Version & Regression Information

  • This is the behavior in every version I tried (from 4.4 onward, when we added aliased conditions).

⏯ Playground Link

Playground Link

💻 Code

interface Foo {
    getValues(): number[];
}

declare const foo: Foo | undefined;

const vals = foo?.getValues();
if (vals) {
    foo; // Foo | undefined
}

const vals2 = foo && foo.getValues();
if (vals2) {
    foo; // Foo
}

if (foo?.getValues()) {
    foo; // Foo
}

🙁 Actual behavior

foo is potentially undefined in the first if block. The assignments fail.

(Added assignments so there's some feedback now that the playground's //^? doesn't work pre-4.6.)

🙂 Expected behavior

foo is narrowed to Foo in the first if block, matching the narrowing in the other if blocks.

コントリビュヌタヌガむド