Microsoft/TypeScript

API: incorrect declarations in types.ts

オープン

#24,706 opened on 2018/06/05

 (5 件のコメント) (12 件のリアクション) (0 人の担当者)TypeScript (13,395 件のフォーク)batch import
Breaking ChangeHelp WantedInfrastructure

Repository metrics

Stars
 (108,860 個のスター)
PR merge metrics
 (PR metrics pending)

説明

The --strictNullChecks PR changed some declarations in types.ts to avoid frequent assertions in the compiler's code. Unfortunately these changes make it really unsafe for API users because they no longer contain the actually nullable types: https://github.com/Microsoft/TypeScript/pull/22088#discussion_r184149465 https://github.com/Microsoft/TypeScript/pull/22088#discussion_r184155027

  • ts.Node#parent is no longer optional (which is definitely wrong for SourceFile)
  • ts.Symbol#declarations and ts.Symbol.valueDeclaration are no longer optional, but can still be undefined
  • ts.Type#symbol is no longer optional, but I guess this comment is still up to date: // Symbol associated with type (if any)

These changes should either be reverted or replaced in the published declaration files. /cc @andy-ms @weswigham

コントリビューターガイド