Microsoft/TypeScript

Feedback to improve compileOnSave with tsserver.

オープン

#17,630 opened on 2017/08/05

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (13,395 件のフォーク)batch import
Domain: APIHelp WantedSuggestionVS Code Tracked

Repository metrics

Stars
 (108,860 個のスター)
PR merge metrics
 (PR metrics pending)

説明

I have implemented inside Eclipse compile on save with tsserver by consuming compileOnSaveAffectedFileList and compileOnSaveEmitFile commands. It works great but I think we could again improved it

For compileOnSaveAffectedFileList:

  • compileOnSaveAffectedFileList should throw error when the given file is excluded of tsconfig.json. It will give the capability to display an error dialog when user wishes to compile a ts file which is excluded by tsconfig.json
  • in some case, tsserver compileOnSaveAffectedFileList returns *.d.ts files (see ttps://github.com/angelozerr/typescript.java/issues/190#issuecomment-317876026) those *.d.ts files must be ignored for compilation.

For compileOnSaveEmitFile:

  • the reponse compileOnSaveEmitFile should return diagnostics errors. I had to call the two tsserver commands syntacticDiagnosticsSync and semantacticDiagnosticsSync after the call of compileOnSaveEmitFile to display errors in the Eclipse "Problem View"
  • the reponse compileOnSaveEmitFile should return the emited files path (js and *.js.map). In Eclipse case it's very helpful because I could refresh the files.

コントリビューターガイド