Formatter fails to format uglified files · Microsoft/TypeScript#10126

(2 comments) (0 reactions) (0 assignees)TypeScript (48,455 stars) (6,726 forks)batch import

Domain: FormatterHelp WantedSuggestionVS Code Tracked

説明

TypeScript Version: 1.8.10

I use vscode from the Command Palette to format a javascript file uglified by uglify-js, but it failed. It not format code correctly, and only format partially.

source file 2016-07-12 4 47 08

sublime jsFormat formated 2016-07-12 4 47 29

vscode formated 2016-07-12 4 47 45

You see, It seems like, vscode only add some spaces around brackets, letters, commas etc.

See https://github.com/Microsoft/vscode/issues/8914#issuecomment-231978337 and the discussion below for more details. The provided traces clearly show that the tsserver only returns white space (" ") changes. No insertion of new lines.

コントリビューターガイド

技術スタック: typescriptjavascript
領域: developer experiencetooling
Issue 種別: bug
難度: 3
推定時間: 1-2 days
活動状況: stale
明確さ: mostly clear
前提条件: Basic understanding of TypeScript's formatter internals
初心者向け度: 10
調査方針: Investigate the TypeScript formatter source code, likely in src/services/formatting/, to understand how it handles whitespace and line breaks. The issue indicates that the formatter only inserts spaces but not new lines for minified code. Reproduce with a uglified JS file and trace the formatting output. Look for relevant tests or linked issues like https://github.com/Microsoft/vscode/issues/8914 for additional context.