ManimCommunity/manim

Add tuple key support in `GenericGraph.__getitem__()`

クローズ

#3,798 opened on 2024/06/09

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)Python (1,378 件のフォーク)batch import
good first issuenew feature

Repository metrics

Stars
 (17,820 個のスター)
PR merge metrics
 (平均マージ 90d 10h) (30d で 31 merged PRs)

説明

Description of proposed feature

vertices = [1, 2, 3, 4]
edges = [(1, 2), (2, 3), (3, 4), (1, 3), (1, 4)]
g = Graph(vertices, edges)
assert isinstance(g[1], Dot)  # This is OK
assert isinstance(g[(1, 2)], Line)  # But this will raise a KeyError

imo This is confusing. Why not add a support for edge mapping?

How can the new feature be used?

Every time people want to get or set a edge, just write g[(1, 2)] instead of g.edges[(1, 2)].

コントリビューターガイド