ManimCommunity/manim

Lagging animations with updaters and self.add

Open

#1,648 opened on 2021年6月7日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Python (1,378 forks)batch import
help wantedissue:bug

Repository metrics

Stars
 (17,820 stars)
PR merge metrics
 (平均マージ 90d 10h) (30d で 31 merged PRs)

説明

Description of bug / unexpected behavior

Animations behave differently depending on the way the mobject was added to the scene. If I use self.play(Create(mobj)) there is no lag, if I use self.add(mobj) the animation lags in certain cases.

Expected behavior

IMHO there should be no difference between the two cases. Also, if using self.add is discouraged for objects that have updaters, we might consider printing a warning.

How to reproduce the issue

See the following code:

from manim import *

class Test(Scene):
    def construct(self):
        tracker = ValueTracker(-3)
        rect = Rectangle().set_x(tracker.get_value())
        label = Text("x")
        rect.add_updater(lambda m: m.set_x(tracker.get_value()))
        label.add_updater(lambda m: m.move_to(rect.get_center()))
        self.add(rect,label)
        self.play(tracker.animate.set_value(4))
        self.wait()
        self.play(FadeIn(rect))
        self.play(tracker.animate.set_value(-4))
        self.wait()
from manim import *

class Test(Scene):
    def construct(self):
        tracker = ValueTracker(-3)
        rect = Rectangle().set_x(tracker.get_value())
        label = Text("x")
        rect.add_updater(lambda m: m.set_x(tracker.get_value()))
        label.add_updater(lambda m: m.move_to(rect.get_center()))
        self.add(rect,label)
        self.play(tracker.animate.set_value(4))
        self.wait()
        #self.play(FadeIn(rect))
        self.add(rect)
        self.play(tracker.animate.set_value(-4))
        self.wait()

Additional media files

https://user-images.githubusercontent.com/52650214/120992430-e36a4300-c782-11eb-80e4-d228dae55858.mp4

コントリビューターガイド