ManimCommunity/manim

Using pluggy for managing Plugins

Open

#1,133 opened on 2021年3月21日

GitHub で見る
 (10 comments) (4 reactions) (0 assignees)Python (1,378 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (17,820 stars)
PR merge metrics
 (平均マージ 90d 10h) (30d で 31 merged PRs)

説明

Enhancement proposal

Pluggy: https://pluggy.readthedocs.io/

Currently how out plugin system works is

With pluggy in place, we can decide the parts of the library which can be extendable without subclassing, see an example. https://pluggy.readthedocs.io/en/latest/#a-toy-example And it feels like we shouldn't reinvent the wheel rather than using something which is already available.

Additional comments

This would kinda require all the plugins to update to use pluggy. Let the previous implementation of importing to global namespace stay, for backward compatibility.


Proof of concept

  • #2635

コントリビューターガイド