Maakaf/friends-activity-backend
refactor - github service - inject octokit and use abstraction level to remove coupling
オープン
#56 opened on 2025/10/30
hacktoberfest
Repository metrics
- Stars
- (9 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
while trying to write the more "interesting" utests for GithubService, i came to realize that it would be a lot easier to mock and test if octokit (and Logger for that matter) would be injected.
So i would like to refactor the service such that it expects an abstraction and use octokit to implement it. this would:
- enable easier mocking in utests.
- remove strong couling we have today between octokit and github service.
@UrielOfir @barlavi1 @Lidor57 - any thoughts about this ?