callback: lr monitorfeaturehelp wantedrefactor
Repository metrics
- Stars
- (26,687 個のスター)
- PR merge metrics
- (平均マージ 9d 15h) (30d で 3 merged PRs)
説明
Outline & Motivation
self.last_momentum_valuesdoes not seem needed, but I may be overlooking something.- Instead of returning the name with
-momentumsuffix when logging betas, just log it with-betasuffix. - If logging betas, log all of them. The name could therefore be
-beta0,-beta1in the case of Adam. - Change the current logging names, e.g.,
lr-Adamtooptimizer-Adam-lrandlr-Adam-momentumtooptimizer-Adam-momentum(it doesn't have momentum this is just for demonstration, it would actually beoptimizer-Adam-beta0,optimizer-Adam-beta1). - remove the
log_momentumargument as it can be inferred automatically.
Pitch
Happy to open a PR with these changes.
Additional context
No response
cc @borda @justusschock @awaelchli