Kovah/LinkAce

Add support for password files

Open

#199 opened on 2020年12月31日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)PHP (1,761 stars) (111 forks)batch import
EnhancementHelp wanted

説明

Is your feature request related to a problem? Please describe. Specifying passwords in environment variables is not always the best available approach. Docker swarm, for example, has support for the concepts of secrets. These are in-memory files mounted in containers under /var/run. To support the use of these secrets, an app must support reading passwords from files.

Describe the solution you'd like Add support for DB_PASSWORD_FILE and DB_REDIS_PASSWORD_FILE environment variables that, if set, will read the passwords from the specified path instead of the regular environment variables.

Describe alternatives you've considered Using the .env file, but it doesn't solve the issue as Docker's secret management can't be used with it.

Additional context None.

コントリビューターガイド

技術スタック
なし
領域
backendsecurity
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
knowledge of PHP environment variable handlingfamiliarity with Docker secrets
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate how environment variables like DB PASSWORD are currently read in the codebase, likely in config/database.php or similar. Then implement logic to check for DB PASSWORD FILE and read the file contents if set. Ensure to handle file not found errors gracefully. Review the two existing comments in the issue for any additional clarification.
Add support for password files · Kovah/LinkAce#199 | Good First Issue