Knockout-Contrib/Knockout-Validation

Consistent coding style suggestions

Open

#488 opened on 2014年12月23日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,024 stars) (394 forks)batch import
help wanted

説明

I'm considering making some changes which should help us have a more maintainable and uniform source code. Here's what I have in mind:

  • make all directories lowercase (Dist -> dist, Src -> src)
  • ensure consistent coding style using http://editorconfig.org/
  • use spaces instead of tabs - e.g. gruntfile looks really bad when open in Github
  • add more JSHint rules

Although it's not critical to implement this right now, I want to have some feedback before going further. I would prefer to have this pushed to v2 release since we have a lot of changes since last release and it would be a good time for it - v2 release notes here.

Feel free to share your ideas to make this project better.

コントリビューターガイド

技術スタック
javascriptnodejs
領域
developer experiencetooling
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Basic knowledge of Knockout JSFamiliarity with grunt
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
55
調査方針
The issue proposes several coding style improvements like renaming directories to lowercase, adding EditorConfig, enforcing spaces instead of tabs, and adding JSHint rules. Check the comments for any feedback from maintainers or contributors. Since the issue is from 2014 and no linked PR exists, it may be stale. Investigate if the maintainers still plan to implement these changes for v2 or if they have been addressed elsewhere.