JuliaPlots/Plots.jl

[FR] `append!` cannot accept collections (as would be expected from the name)

Open

#4,825 opened on 2023年9月19日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)Julia (1,943 stars) (381 forks)batch import
enhancementgood first issue

説明

The signature of the append! method through which all others pass accepts only Real..., meaning it cannot actually add multiple datapoints to a series. It is my understanding that in Julia, append! is generally meant to be the bulk equivalent of push!, but because of this signature, append! for plots is just a less flexible version of push!.

The problematic method definition: https://github.com/JuliaPlots/Plots.jl/blob/7cd27c470e10d8364ab935935eb58a97eae55ce3/src/utils.jl#L810C1-L810C90 image

If I understand correctly, just making the type of args less restrictive, to include vectors, would fix this. The signature of the previous method should probably also be changed for consistency but that would be a breaking change.

コントリビューターガイド

技術スタック
なし
領域
data
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Julia programming basicsUnderstanding of method signaturesFamiliarity with Plots.jl
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
The issue points to a specific method definition in src/utils.jl at line 810, where the signature restricts args to Real. The fix involves changing the type to accept collections (e.g., Vector). However, this could break other callers, so examine all uses of the method. Also check the previous method definition for consistency. The maintainer may have opinions on the best approach.