JuliaDynamics/RecurrenceAnalysis.jl

Source code clarity of `recurrence_matrix`

オープン

#136 opened on 2022/05/22

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Julia (16 件のフォーク)auto 404
claritygood first issue

Repository metrics

Stars
 (50 個のスター)
PR merge metrics
 (PR metrics pending)

説明

At the moment the source code of recurrence_matrix, which is where the central computations of a recurrence matrix take place, is full of duplication. There version complexity scales as 2 x 2 x 2 = 8, with a multiplicity of 2 for (recurrences vs cross-recurence), (parallel vs non parallel), (dataset vs vector).

I do not believe that having 8 different methods is necessary. In fact, it may even be that we could do everything with 1 or 2 methods, by defining smaller helper functions.

In any case, a multiplicity of 8 is certainly not necessary and the source code can be simplified to remove duplication and thus make long term maintanance also easier.

コントリビューターガイド