Juanpe/SkeletonView

Does not work with new UICollectionView Compositional Layout

オープン

#321 opened on 2020/09/04

 (9 件のコメント) (0 件のリアクション) (0 人の担当者)Swift (1,126 件のフォーク)batch import
featurehelp wantedtriaged

Repository metrics

Stars
 (12,895 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

⚠️ Please fill out this template when filing an issue.

🙏🏼 Please check if it already exists other issue related with yours.

What did you do?

Implemented a UICollectionView using the new Compositional Layout feature.

Then added this to viewDidLoad()

DispatchQueue.main.async {
            self.collectionView.showSkeleton()
        }

What did you expect to happen?

Expected to see the skeleton view applied to the UICollectionView

What happened instead?

I assume that since UICollectionView implementations that use Compositional Layout use diffable datasources instead of implementing the CollecitonView data source the skeleton view was not applied to my collectionview cells.

Steps to reproduce the behavior

Implement a UICollectionView with Compositional Layout and try applying the SkeletonView

SkeletonView Environment

SkeletonView version: SkeletonView (1.8.8) Xcode version: 11.7 Swift version: 5.2

コントリビューターガイド