Improve `:all` bottle coverage · Homebrew/homebrew-core#191352

(8 comments) (5 reactions) (0 assignees)Ruby (15,288 stars) (13,532 forks)batch import

good first issuehelp wanted

説明

We currently have a few hundred :all bottles in this repository. I count another 200 or so more (see candidate formulae below) that could have an :all bottle but don't currently have one.

These are typically due to /usr/local references inside that bottles that are relocated on x86_64 macOS but not on arm64 macOS or Linux. To fix these, we typically only need a few inreplace lines. See below for example PRs.

diffoscope is your best friend here (install it with brew intall diffoscope).

If you're trying to fix formula foo, you'll want to first check foo for which bottles have different checksums, e.g., with brew cat foo (if you have homebrew/core tapped), or with

brew info --json=v2 foo | jq '.formulae[].bottle.stable.files'

Typically, the Intel macOS bottles will all have the same checksums, but these will be different from the arm64 macOS bottles and Linux bottles (which often all have the same checksums as well).

Pull down the relevant bottles with:

brew fetch --bottle-tag arm64_sonoma foo
brew fetch --bottle-tag sonoma foo

and then examine them using diffoscope:

diffoscope "$(brew --cache --bottle-tag arm64_sonoma foo)" "$(brew --cache --bottle-tag sonoma foo)"

diffoscope will tell you which files differ, and these are the ones you'll want to inreplace.

An :all bottle can be installed by any Homebrew user, regardless of their HOMEBREW_PREFIX or OS version, so having more :all bottles mean that more users can benefit from bottle usage.

Moreover, :all bottles are a signal that our builds are (somewhat) reproducible, which is important when providing pre-built packages. See https://reproducible-builds.org for more on this.

コントリビューターガイド

技術スタック: ruby
領域: build systemrelease
Issue 種別: feature
難度: 2
推定時間: 1-3 hours
活動状況: active
明確さ: clear
前提条件: Homebrew basicsRuby DSLdiffoscope tool
初心者向け度: 90
調査方針: Choose a formula from the list of candidates that is not yet marked with [x] in the issue. Follow the instructions to fetch bottles for different OS versions and use diffoscope to find differences. Then add inreplace lines to the formula's Ruby file to fix hardcoded paths. Reference the provided example PRs for guidance. Ensure the fix results in matching checksums across all platforms.