HabitRPG/habitica

Removing user from party does not prompt a check on whether a pending quest can start

Open

#11,566 opened on 2019年11月22日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)JavaScript (10,775 stars) (3,912 forks)batch import
help wantedpriority: minorsection: Party Page

説明

Jorayaho @Jorayaho (ab9c48bb-6b86-48dc-b3da-4fd0bac6a89c) [web] Hi, I just encountered an issue with a quest. 3 out of 4 party members accepted the quest invitation. I kicked the one who didn't accept. Quest didn't force-start (maybe the check if force-start is needed is only executed when a member accepts/declines) and when I started it manually it said not all party members accepted, only 3 out of 3.

Not yet tested; if anyone does have the chance to test this and confirm, that would be appreciated.

コントリビューターガイド

技術スタック
javascriptnodejsmongodb
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
blocked
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Node.jsMongoDBknowledge of Habitica's quest system
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
35
調査方針
Investigate the quest start logic in the party model. Look at the function that triggers quest start upon member acceptance/decline. Check if there is a similar trigger when a member is removed. Examine files such as 'models/party' or 'controllers/quest' to understand the flow. Consider adding a check after removal to see if all remaining members have accepted and if the quest can start.