HabitRPG/habitica

Refactor Justin intro modal to separate it from avatar edit

Open

#10,803 opened on 2018年11月2日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)JavaScript (10,775 stars) (3,912 forks)batch import
help wantedpriority: minorsection: Avatar/User Modal

説明

Description

creatorIntro.vue is used both for initial avatar setup on account creation, and for editing a user's avatar via the user menu. This makes it difficult to consistently position both modals, because ideal positioning for the Justin sequence pushes the much larger avatar edit modal partially offscreen.

What we should do is pull the shared avatar-related pieces out to a component that's then plugged into two separate modals, Justin and post-setup avatar editing. Then, reposition the Justin sequence so it's centered better onscreen.

コントリビューターガイド

技術スタック
vuejavascript
領域
frontend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Vue.jsunderstanding of component refactoringknowledge of modal UI patterns
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Examine the current `creatorIntro.vue` component to understand how it handles both the Justin intro and avatar editing. Identify the shared avatar related pieces (likely the avatar preview and controls) that can be extracted into a separate component. Then, create two new modals: one for the Justin sequence and one for post setup avatar editing, each using the shared component. Ensure the Justin sequence modal is repositioned to be centered on screen.