GoogleContainerTools/skaffold

Bug/feature req: Show errors from Lifecycle hook when it fails

Open

#7,019 opened on 2022年1月17日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Go (12,822 stars) (1,416 forks)batch import
area/status-checkhelp wantedkind/enhancementpriority/p3

説明

Expected behavior

If a lifecycle hook fails, and the pod fails to start up, its "invisible" to the skaffold user, I expected it to log events from the lifecycle hooks.

Actual behavior

Waiting, and then terminating without any obvious reason to why

Information

  • Skaffold version: 1.29.0
  • Operating system: Fedora 32
  • Installed via: gcloud components / package manager

Steps to reproduce the behavior

Event logs fetch via Lens:

Exec lifecycle hook ([php bin/console cache:warmup -n]) for Container "eportal" in Pod "eportal-6cc67c6456-sgb9z_morten(b3217653-88da-4970-955d-8012e1aed6d6)" failed - error: command 'php bin/console cache:warmup -n' exited with 1: In DefinitionErrorExceptionPass.php line 54: Cannot autowire service "App\Controller\ApiOperations\Group\GetAvailableGro upMeetings": argument "$request" of method "__construct()" references class "Symfony\Component\HttpFoundation\Request" but no such service exists. , message: "\nIn DefinitionErrorExceptionPass.php line 54:\n \n Cannot autowire service \"App\\Controller\\ApiOperations\\Group\\GetAvailableGro \n upMeetings\": argument \"$request\" of method \"__construct()\" references class \n \"Symfony\\Component\\HttpFoundation\\Request\" but no such service exists. \n \n\n"

コントリビューターガイド

技術スタック
gokubernetesdocker
領域
backenddevops
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
needs investigation
前提条件
Goskaffold lifecycle hooksKubernetes pod lifecycle
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Examine how Skaffold runs lifecycle hooks in deploy/deploy.go and related files. Look for where the hook command output is captured or lost. The issue suggests that when a hook fails, Skaffold does not log the error. Find the code that executes the hook and check if the output is being printed to the user. Consider adding logic to log the hook's stderr/stdout on failure.