GoogleCloudPlatform/testgrid

Config Merger only reads configuration on startup; should be more often

オープン

#517 opened on 2021/06/23

 (0 件のコメント) (1 件のリアクション) (0 人の担当者)Go (72 件のフォーク)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (205 個のスター)
PR merge metrics
 (PR metrics pending)

説明

The Config Merger is a controller that takes multiple configurations and merges them together. It requires a list of configurations to merge together.

https://github.com/GoogleCloudPlatform/testgrid/blob/651499da486f08c6ba6fcfa7efb1535318c22fa5/cmd/config_merger/main.go#L93

It then periodically reads those configs and merges them together. Changes in the config are picked up in this loop, but changes to the config list are not.

https://github.com/GoogleCloudPlatform/testgrid/blob/651499da486f08c6ba6fcfa7efb1535318c22fa5/cmd/config_merger/main.go#L111-L125

This has caused issues when the config is changed, and Config Merger silently ignores those changes until it's rebooted. See https://github.com/GoogleCloudPlatform/oss-test-infra/issues/919

Additional logic to determine if the config list has changed and to either log this event or do less work if it hasn't changed would also be nice.

コントリビューターガイド