GoogleChromeLabs/quicklink

Consider adding `rootMargin` to the Intersection Observer

Open

#14 opened on 2018年12月10日

GitHub で見る
 (13 comments) (1 reaction) (0 assignees)JavaScript (431 forks)batch import
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (10,861 stars)
PR merge metrics
 (平均マージ 47d 12h) (30d で 4 merged PRs)

説明

Feedback from @surma:

I feel like by default you should add a rootMargin to the IO to trigger the load before something comes into the viewport.

So, rootMargin defaults to "0px 0px 0px 0px", meaning the intersection will be computed between the root element's unmodified bounds rectangle and the target's bounds. This change would be made to https://github.com/GoogleChromeLabs/quicklink/blob/master/src/index.mjs#L21

コントリビューターガイド