Glavin001/tslint-clean-code

Create a whitelist for id-length rule

Open

#40 opened on 2018年2月13日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)TypeScript (15 forks)github user discovery
buggood first issuehelp wanted

Repository metrics

Stars
 (175 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Hello and thank you for your work.

The id-length rule is great for forbidding one-letter variable names. However, there are cases where one-letter symbols would actually be preferred: type parameters (GenericTypeAnnotation nodes) and holes.

Holes

Array
  .from({ length: 10 })
  .map((_, index) => index);

Type parameters

function unique<T>(collection: T[]): T[] {
  return [...new Set(collection)];
}

What do you think about passing a config that would allow them?

"id-length": [true, {
  "check-type-parameters": false,
  "allow": ["_"]
}]

コントリビューターガイド