refactor(fmt): use `drain_filter` during comment formatting when stabilized · FuelLabs/sway#3925

(1 comment) (0 reactions) (0 assignees)Rust (61,702 stars) (5,421 forks)batch import

P: lowgood first issue

説明

BTreeMap does not have an equivalent for Range that also removes the yielded elements, however it does have a > drain_filter method.

A more efficient (performance and code-wise) alternative to this function using drain_filter might look like:
formatter.comment_map.drain_filter(|bs, _v| bs.start >= start && bs.end <= end)

Originally posted by @mitchmindtree in https://github.com/FuelLabs/sway/pull/3854#discussion_r1083691334

Currently, drain_filter is a a nightly-only API - I opted to use retain instead to filter out already formatted comments. We can perhaps consider doing this once drain_filter is stabilized.

コントリビューターガイド

技術スタック: rust
領域: tooling
Issue 種別: refactor
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: mostly clear
前提条件: RustBTreeMap drain filternightly Rust
初心者向け度: 30
調査方針: This issue proposes replacing `retain` with `drain filter` in comment formatting when that API stabilizes. The relevant code is in swayfmt/src/comments.rs lines 59-64, and the original suggestion came from PR #3854. To proceed, monitor Rust nightly for `drain filter` stabilization, then implement the change. No current activity or assignee.