FreeTubeApp/FreeTube

SponsorBlock - Add Unskip/Reskip

Open

#1,380 opened on 2021年6月1日

GitHub で見る
 (10 comments) (9 reactions) (0 assignees)JavaScript (9,938 stars) (600 forks)batch import
U: doesn't follow templateenhancementhelp wanted

説明

I've started using the SponsorBlock feature for a while and it has been working quite well as it should. However, I found the fact that you can't choose to see an ad without having to disable the feature in the settings quite bothersome.

My suggestion to tackle this issue would be to make the auto-skip an option in the SponsorBlock's settings. Thus, when chosen, the program would function that same as currently does, and, when not, the user would manually skips the ad via a "skip this ad" button (in similar fashion of YouTube's ads).

I believe this to be the best option since it covers for the users that don't care the slightest for ads and those that sometimes do.

コントリビューターガイド

技術スタック
javascriptelectron
領域
desktop
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with FreeTube codebaseUnderstanding of SponsorBlockJavaScript knowledge
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
Investigate the SponsorBlock integration in FreeTube, likely in the src/sponsorblock/ directory. Identify where auto skip is implemented and where settings are defined. Look for existing toggle patterns in the settings UI to replicate. Consider adding a new setting option for auto skip and implementing a manual skip button that appears during sponsored segments. Review the existing test coverage for SponsorBlock to understand expected behavior.